mxqd: Remove RLIMIT_CPU usage for runtime limitation #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code applies a RLIMIT_CPU limit to jobs with `job_threads == i`. This is incorrect, as such jobs can still get more processors if they require more server slots because of their memory demands. Since mxqd can now monitor and reliably kill jobs that exceed their allowed runtime, this code is obsolete and no longer useful. There is no reason to fix this code, so remove it entirely.
Sign in
to join this conversation on GitHub.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code applies a RLIMIT_CPU limit to jobs with
job_threads == i. This is incorrect, as such jobs can still get more processors if they require more server slots because of their memory demands.Since mxqd can now monitor and reliably kill jobs that exceed their allowed runtime, this code is obsolete and no longer useful.
There is no reason to fix this code, so remove it entirely.
Fixes #165